Fix grouped modifications search #3436
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sBouzols
reviewed
Nov 4, 2025
Comment on lines
135
to
136
| ? 'rootNetwork.searchPlaceholder.nodes' | ||
| : 'rootNetwork.searchPlaceholder.modifications', |
There was a problem hiding this comment.
Suggested change
| ? 'rootNetwork.searchPlaceholder.nodes' | |
| : 'rootNetwork.searchPlaceholder.modifications', | |
| ? 'rootNetwork.searchLabel.nodes' | |
| : 'rootNetwork.searchLabel.modifications', |
sBouzols
reviewed
Nov 4, 2025
Comment on lines
129
to
131
| placeholder={intl.formatMessage({ | ||
| id: 'searchPlaceholder', | ||
| })} |
There was a problem hiding this comment.
Suggested change
| placeholder={intl.formatMessage({ | |
| id: 'searchPlaceholder', | |
| })} |
remove placeholder ? the label usage is sufficient no ?
sBouzols
approved these changes
Nov 5, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Minor changes on the placeholder and the label of the search bar in modifications search dialog and nodes search dialog.